> > > + u32 irq_flags; > > const char *name = NULL; > > Don't know if OF style requires reversed xmas tree order. If so, this should be > > const char *name = NULL; > u32 irq_flags; > I see both methods used. For example, of_irq_init() uses normal xmas tree order. I'll leave it unless Rob says otherwise. It is Christmas time, so I do want to honor the Christmas trees appropriately!