On Mon, Dec 25, 2023 at 01:39:29PM +0800, Shenghao Ding wrote: > Move tas2563 from tas2562 header file to tas2781 header file, because > tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to > enable DSP mode for tas2563, it has been moved to tas2781 driver. As to > the hardware part, such as register setting and DSP firmware, all these > are stored in the binary firmware. What tas2781 drivder dooes is to parse > the firmware and download them to the tas2781 or tas2563, then power on > tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver。 > Only attention will be paid to downloading corresponding firmware. > enum audio_device { > TAS2781 = 0, > + TAS2563 > }; Please, make it ordered, it doesn't seem to be an ABI. enum audio_device { TAS2563, TAS2781, }; Yes, and leave comma as the last entry is _not_ a terminator. -- With Best Regards, Andy Shevchenko