On 26/12/2023 14:14, Jie Luo wrote: > >>>>> >>>>> This does not resolve mine and Conor's concerns from previous version. >>>>> External clocks are defined as clock inputs. >>>> >>>> No matter the external or internal reference clock, they are the clock >>>> source selection for CMN, there are only 48MHZ can be external or >>>> internal, other clocks have the different clock rate, so the internal >>>> 48MHZ reference clock can be implied when the >>>> "qcom,cmn-ref-clock-frequency" is not defined, which is suggested by >>>> Conor in the previous >>>> comments. >>> >>> I don't think he proposed it, but maybe I missed some message (care to >>> point me to his message where he agreed on usage of >>> qcom,cmn-ref-clock-frequency?). I am pretty sure we both stayed on the >>> same page, that the presence of clocks defines choice of internal clock. >>> This property should go away. >> >> Exactly, I wanted this property to be removed. My suggestion was about >> defaulting to the internal clock when the "clocks" property did not >> contain the cmn ref clock. > > There are two internal reference clock sources 48MHZ and 96MHZ. On which devices? Paste entire picture, not half-baked descriptions. > The 96MHZ is used on ipq5018 currently as i said in the previous > message, but it is also possible to used on ipq9574 per double checked, > since the possible reference clock source should be kept as configurable > and the clock source should not be limited on the specific IPQ platform, > since the clock source is configurable, the different clock source maybe > required by the different board design. I don't see how this answers anything about our suggestions. Best regards, Krzysztof
