On Sat, Dec 23, 2023 at 07:40:28PM +0100, Krzysztof Kozlowski wrote: > On 20/12/2023 22:36, Frank Li wrote: > > iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required > > proptery for iMX8MQ to indicate pci controller index. > > > Why it has to be required? Everything will work fine if skipped. > Otherwise please provide reason why it must be *required*. Next patch will use "linux,pci-domain" as PCI slot ID, instead compared with hard code register address. The below code will be removed. - if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) - imx6_pcie->controller_id = 1; when there are more than 2 controller, this compare logic will become complex. So after next patch, "linux,pci-domain" will be required. Frank > > Best regards, > Krzysztof >
