Hi Conor, Thanks for the reviews. On Fri, 2023-12-22 at 15:07 +0000, Conor Dooley wrote: > On Fri, Dec 22, 2023 at 12:52:21PM +0800, Jason-JH.Lin wrote: > > Add mboxes to define a GCE loopping thread as a secure irq handler. > > This property is only required if CMDQ secure driver is supported. > > What do drivers have to do with this? Either the mailbox channel > exists > or it does not. That said, I am not sure why this should be in DT in > the > first place, can't the driver for the mailbox controller reserve a > channel for its own use? > > Thanks, > Conor. Since we implemented our mtk-cmdq-mailbox driver with mailbox frameworks, one mbox channel bounds to a GCE HW thread. So if we want to request a mbox channel for using a GCE HW thread for secure irq handler in mtk-cmdq-mailbox driver itself, I think we need to add this property to DT. Regards, Jason-JH.Lin [snip]
