Rob, thank you very much for your feedback. On Mon Dec 18, 2023 at 4:17 PM CET, Rob Herring wrote: > > + Marvell 88PM880 and 88PM886 are two similar PMICs providing > > + several functions such as onkey, regulators or battery and > > + charger. Both seem to come in two revisions -- A0 and A1. > > + > > +properties: > > + compatible: > > + const: marvell,88pm886-a1 > > The description talks about 4 different devices, but only 1 here. > > Do you expect to need A0 support? Devices with these PMICs should be > known and few, right? I know of three smartphones which have 88PM886 and all of them (at least the revisions that have been tested) seem to use A1. So no, I don't know of any device that would need A0, but I wanted have the driver ready in case somebody needed to add it later. What change do you then suggest? Thank you and kind regards, K. B.
