On 22/12/2023 12:05, Manuel Traut wrote: > Add bindings for the BOE TH101MB31IG002-28A LCD panel. It is > used e.g. in the Pine64 Pinetab2 and PinetabV. > > Signed-off-by: Manuel Traut <manut@xxxxxxxxx> > --- > + > +maintainers: > + - Manuel Traut <manut@xxxxxxxxx> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + enum: > + # BOE TH101MB31IG002-28A 10.1" WXGA TFT LCD panel > + - boe,th101mb31ig002-28a > + > + reg: reg: true > + description: the virtual channel number of a DSI peripheral > + > + backlight: : true > + description: phandle of the backlight device attached to the panel Because there is really no need to repeat obvious. > + > + enable-gpios: > + description: a GPIO spec for the enable pin Ditto > + > + power-supply: > + description: core voltage supply Ditto > + > + And drop redundant blank lines. > + ports: true Hm, why ports? From where did you copy it? > + rotation: true > + > +required: > + - compatible > + - reg > + - enable-gpios > + - power-supply > + > +additionalProperties: false > + > +examples: > + - | > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "boe,th101mb31ig002-28a"; > + reg = <0>; > + backlight = <&backlight_lcd0>; > + enable-gpios = <&pio 45 0>; Use define for GPIO flag. Best regards, Krzysztof