On 22/12/2023 16:01, Krzysztof Kozlowski wrote: > > +static int wsa884x_get_reset(struct device *dev, struct wsa884x_priv *wsa884x) > +{ > + wsa884x->sd_reset = devm_reset_control_get_optional_shared(dev, NULL); > + if (IS_ERR(wsa884x->sd_reset)) > + return dev_err_probe(dev, PTR_ERR(wsa884x->sd_reset), > + "Failed to get reset\n"); > + When cleaning up the patchset I removed one piece too much. I should have here: if (wsa884x->sd_reset) return 0; Best regards, Krzysztof