On Thu, Dec 21, 2023 at 04:59:42PM -0700, Mark Hasemeyer wrote: > >> > > -int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index) > >> > > +int fwnode_irq_get_resource(const struct fwnode_handle *fwnode, > >> > > + unsigned int index, struct resource *r) > >> > > >> > It's perfectly fine to replace ) by , on the previous line, no need > >> > to make it shorter. > >> > >> That puts the line at 115 chars? checkpatch.pl allows a maximum line > >> length of 100. I can bump the 'index' argument up a line and keep it > >> to a length of 95? > > > > clang-format should do the right thing. > > It formats the line as-is in the patch: with 'unsigned int index' on > the next line. Exactly, and I don't think we need that "smartness" in this case. -- With Best Regards, Andy Shevchenko