On 22.12.2023 09:12, Krzysztof Kozlowski wrote: > On 22/12/2023 05:39, Bjorn Andersson wrote: >> In some designs the SoC's VDD_GFX pads are supplied by an external >> regulator, rather than a power-domain. Allow this to be described in the >> GPU clock controller binding. >> >> Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/clock/qcom,gpucc.yaml | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml >> index f369fa34e00c..c0dd24c9dcb3 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml >> @@ -53,6 +53,9 @@ properties: >> power-domains: >> maxItems: 1 >> >> + vdd-gfx-supply: >> + description: Regulator supply for the VDD_GFX pads >> + >> '#clock-cells': >> const: 1 >> >> @@ -74,6 +77,19 @@ required: >> - '#reset-cells' >> - '#power-domain-cells' >> >> +# Allow either power-domains or vdd-gfx-supply, not both >> +oneOf: >> + - required: >> + - power-domains >> + - required: >> + - vdd-gfx-supply > > This should be enough, assuming one of them is actually required. The > code. See also: > https://elixir.bootlin.com/linux/v5.17-rc2/source/Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml#L91 At least one of them indeed is, though this change is being made implicitly. No clock controller works with no power FWIW Konrad
