Hi Andy Thanks for your reply. The description as below > > > + in_port = GPIO_BANK(gpio->nin_sgpio); > > > + if (GPIO_BIT(gpio->nin_sgpio) > 0) > > > + in_port += 1; > > > > This is strange... So, you are telling that offsets start from 1 and not 0? > > > > > + out_port = GPIO_BANK(gpio->nout_sgpio); > > > + if (GPIO_BIT(gpio->nout_sgpio) > 0) > > > + out_port += 1; > > > > Ditto. > > > Yes, if the customer has defined the in/out pins the offsets start from 1. >Why? The NPCM_IOXCFG2_PORT default setting is to enable 0 input port and 0 output port. The register default value is 0x0. Each port can support 8 pins. If the register value is 0x31 means enable 3 output ports and 1 input port. If customer has define nuvoton,input-ngpios or nuvoton,output-ngpios dts property For example , nuvoton,output-ngpios = <9> > > > + out_port = GPIO_BANK(gpio->nout_sgpio); The out_port value is 1 but one port only supports 8 pins. > > > + if (GPIO_BIT(gpio->nout_sgpio) > 0) > > > + out_port += 1; This out_port value is 2, the driver will enable two port to support 9 pins. Maybe it is my expression error , the out_port and in_port default value is 0. > The NPCM_IOXCFG2_PORT register is the set number of in/out ports. > NPCM_IOXCFG2_PORT register define as below: > 0~3 bit is the number of input ports > 4~7 bit is the number of output ports > Each module can support 8 input ports and 8 output ports. Best regards, Jim
