On 21/12/2023 11:13, Shenghao Ding wrote: > Add tas2563 to better support dsp mode. > > Signed-off-by: Shenghao Ding <shenghao-ding@xxxxxx> > > --- > Change in v2: > - Add devicetree list and other list of necessary people and lists to CC > - Express Compatibility in the bindings Nothing changed in that matter - no compatibility was expressed. ... > > -allOf: > - - $ref: dai-common.yaml# > - > properties: > compatible: > + description: | > + ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker > + Protection and Audio Processing, 16/20/24/32bit stereo I2S or > + multichannel TDM. > + > + ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated > + DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM. > enum: > - ti,tas2781 > + - ti,tas2563 # fallback compatible I don't see any use of fallback. The comment is meaningless. Open example-schema and see how it is done there. > > - reg: > - description: > - I2C address, in multiple tas2781s case, all the i2c address > - aggregate as one Audio Device to support multiple audio slots. > - maxItems: 8 > - minItems: 1 > - items: > - minimum: 0x38 > - maximum: 0x3f > + reg: true No, why? Keep min/maxItems. > > reset-gpios: > maxItems: 1 > @@ -49,6 +46,34 @@ required: > - compatible > - reg > > +allOf: > + - $ref: dai-common.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - ti,tas2781 > + then: > + properties: > + reg: > + description: > + I2C address, in multiple AMP case, all the i2c address > + aggregate as one Audio Device to support multiple audio slots. Description applies to second case as well, so keep it in top-level. Best regards, Krzysztof
