On 21/12/2023 16:07, Andre Przywara wrote: > On Thu, 21 Dec 2023 15:45:17 +0100 > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > Hi, > >> On 21/12/2023 15:06, Andre Przywara wrote: >>> The sunxi.yaml file, holding all known board compatible names for >>> devices with Allwinner SoCs, is apparently sorted alphabetically, by the >>> "description" entry. However there are a few outliers. >>> >>> Re-order the entries to get a strict alphabetical ordering, so that: >>> $ grep description: sunxi.yaml | sort -fc >>> returns empty-handed. There is no change otherwise. >>> >>> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> >> >> What was the existing order? Aren't this just shuffling again things? > > It assume the intention was to order "alphabetically by description", but > there were some out-of-place entries which apparently slipped through > review. > > Shall I add a comment at the top to note the order? Some files like this are ordered by compatible, some by class or family of devices, so first you need to be sure there is no existing order. Best regards, Krzysztof
