On 20/12/2023 21:50, Wolfram Sang wrote: > On Wed, Dec 20, 2023 at 01:58:01PM +0530, Naresh Solanki wrote: >> From: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx> >> >> Maxim Max7357 has a configuration register to enable additional >> features. These features aren't enabled by default & its up to >> board designer to enable the same as it may have unexpected side effects. >> >> These should be validated for proper functioning & detection of devices >> in secondary bus as sometimes it can cause secondary bus being disabled. >> >> Add booleans for: >> - maxim,isolate-stuck-channel >> - maxim,send-flush-out-sequence >> - maxim,preconnection-wiggle-test-enable >> >> Signed-off-by: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx> >> Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Rob, are you really OK with these bindings? They look more like > configuration instead of HW description to me. Some explanation was provided here: https://lore.kernel.org/all/CABqG17g8QOgU7cObe=4EMLbEC1PeZWxdPXt7zzFs35JGqpRbfg@xxxxxxxxxxxxxx/ AFAIU, these properties are board-design choice. Best regards, Krzysztof
