On 20/12/2023 13:40, Mao Jinlong wrote: > Add coresight components on Qualcomm SM8450 Soc. The components include > TMC ETF/ETR, ETE, STM, TPDM, CTI. > > Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 742 +++++++++++++++++++++++++++ > 1 file changed, 742 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 1783fa78bdbc..112b5a069c94 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -285,6 +285,192 @@ CLUSTER_SLEEP_1: cluster-sleep-1 { > }; > }; > > + ete0 { ete-0 > + compatible = "arm,embedded-trace-extension"; > + cpu = <&CPU0>; > + > + out-ports { > + port { > + ete0_out_funnel_ete: endpoint { > + remote-endpoint = <&funnel_ete_in_ete0>; Missing indentation. ... > + funnel_ete { funnel Anyway underscores are not allowed > + compatible = "arm,coresight-static-funnel"; > + > + out-ports { > + port { > + funnel_ete_out_funnel_apss: endpoint { > + remote-endpoint = > + <&funnel_apss_in_funnel_ete>; Messed indentation Errors above look all over this patch, so fix all instances in this patch. Best regards, Krzysztof