On 20.12.2023 11:02, Luca Weiss wrote: > This series adds all the necessary bits to enable USB-C role switching, > charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > One thing that could be made different is the pmic-glink compatible. > I've chosen to use qcm6490 compatible for it and not sc7280 since > there's plenty of firmware variety on sc7280-based platforms and they > might require different quirks in the future, so limit this PDOS quirk > to just qcm6490 for now. > > If someone thinks it should be qcom,sc7280-pmic-glink, please let me > know :) IMO it's best to continue using the "base soc" (which just so happened to fall onto sc7280 this time around) for all compatibles, unless the derivatives actually had changes as far as firmware goes, I *think* CrOS doesn't even have PMIC_GLINK? There are however WoA 7280 laptops which totally should have it.. Would be nice to hunt some down and see if they report different stuff to what's there on android firmware Konrad
