Hi Rafał, zajec5@xxxxxxxxx wrote on Tue, 19 Dec 2023 18:40:25 +0100: > From: Rafał Miłecki <rafal@xxxxxxxxxx> > > This patch moves all generic (NVMEM devices independent) code from NVMEM Nit: In general we avoid starting with "This patch does..." and instead use the imperative form, like: "Move all generic code..." > device driver to NVMEM layout driver. Then it adds a simple NVMEM layout Then add... > code on top of it. > > Thanks to proper layout it's possible to support U-Boot env data stored > on any kind of NVMEM device. > > For backward compatibility with old DT bindings we need to keep old > NVMEM device driver functional. To avoid code duplication a parsing > function is exported and reused in it. > > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> > --- > V2: Support new compatibles & use device_get_match_data() helper > > IMPORTANT: > This is based on top of the: > [PATCH v6.8 1/2] nvmem: layouts: refactor .add_cells() callback arguments Thanks for the move. Looks good to me: Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> Thanks, Miquèl
