JeeHeng Sia wrote: > > > > -----Original Message----- > > From: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> > > Sent: Wednesday, December 13, 2023 7:57 PM > > To: JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx>; Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx>; kernel@xxxxxxxx; > > conor@xxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; paul.walmsley@xxxxxxxxxx; palmer@xxxxxxxxxxx; > > aou@xxxxxxxxxxxxxxxxx; mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; Hal Feng > > <hal.feng@xxxxxxxxxxxxxxxx>; Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> > > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; Leyfoon Tan > > <leyfoon.tan@xxxxxxxxxxxxxxxx> > > Subject: RE: [PATCH v1 06/16] clk: starfive: Add JH8100 System clock generator driver > > > > JeeHeng Sia wrote: > > > > -----Original Message----- > > > > From: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> > > > > Sent: Saturday, December 9, 2023 12:25 AM > > > > To: JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx>; kernel@xxxxxxxx; conor@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > > > > krzysztof.kozlowski+dt@xxxxxxxxxx; paul.walmsley@xxxxxxxxxx; palmer@xxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx; > > > > mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; emil.renner.berthing@xxxxxxxxxxxxx; Hal Feng > > > > <hal.feng@xxxxxxxxxxxxxxxx>; Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> > > > > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; Leyfoon > > Tan > > > > <leyfoon.tan@xxxxxxxxxxxxxxxx> > > > > Subject: Re: [PATCH v1 06/16] clk: starfive: Add JH8100 System clock generator driver > > > > > > > > Sia Jee Heng wrote: > > > > > Add support for JH8100 System clock generator. > > > > > > > > > > Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx> > > > > > Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx> > > > > > --- > > > > > MAINTAINERS | 8 + > > > > > drivers/clk/starfive/Kconfig | 9 + > > > > > drivers/clk/starfive/Makefile | 1 + > > > > > drivers/clk/starfive/clk-starfive-common.h | 9 +- > > > > > drivers/clk/starfive/jh8100/Makefile | 3 + > > > > > .../clk/starfive/jh8100/clk-starfive-jh8100.h | 11 + > > > > > drivers/clk/starfive/jh8100/clk-sys.c | 455 ++++++++++++++++++ > > > > > 7 files changed, 495 insertions(+), 1 deletion(-) > > > > > create mode 100644 drivers/clk/starfive/jh8100/Makefile > > > > > create mode 100644 drivers/clk/starfive/jh8100/clk-starfive-jh8100.h > > > > > create mode 100644 drivers/clk/starfive/jh8100/clk-sys.c > > ... > > > > > diff --git a/drivers/clk/starfive/Makefile b/drivers/clk/starfive/Makefile > > > > > index 012f7ee83f8e..6cb3ce823330 100644 > > > > > --- a/drivers/clk/starfive/Makefile > > > > > +++ b/drivers/clk/starfive/Makefile > > > > > @@ -10,3 +10,4 @@ obj-$(CONFIG_CLK_STARFIVE_JH7110_AON) += clk-starfive-jh7110-aon.o > > > > > obj-$(CONFIG_CLK_STARFIVE_JH7110_STG) += clk-starfive-jh7110-stg.o > > > > > obj-$(CONFIG_CLK_STARFIVE_JH7110_ISP) += clk-starfive-jh7110-isp.o > > > > > obj-$(CONFIG_CLK_STARFIVE_JH7110_VOUT) += clk-starfive-jh7110-vout.o > > > > > +obj-$(CONFIG_CLK_STARFIVE_JH8100_SYS) += jh8100/ > > > > > > > > I don't really see why do you need a special subdirectory for the JH8100? The > > > > JH7110 drivers do fine without it. > > > Each subfolder can represent a different platform, making it easier to > > > locate and maintain platform-specific code. Since the code is expected > > > to grow in the future, let's start organizing it in a folder-based structure > > > for easier maintenance at a later stage. > > > > Yes, but that's not what you're doing here. You're making just one of the 3 > > almost identical drivers be different for no good reason. > I will restructure it for the other 2 platforms. That would be less bad, but you still haven't explained why you need to move everything around like that: https://lore.kernel.org/linux-riscv/CAJM55Z_3Mty2LftPVkQC1wbwtGeznMMAk9mAjH_GoNuL7CKtaQ@xxxxxxxxxxxxxx/ I don't think just "too many files" is a very good argument here. Just look at drivers/clk/sunxi /Emil
