On Mon, Dec 18, 2023 at 05:02:02PM +0100, Konrad Dybcio wrote: > The downstream kernel has infrastructure for passing votes from different > interconnect nodes onto different RPMh RSCs. This neither implemented, not > is going to be implemented upstream (in favor of a different solution > using ICC tags through the same node). > > Unfortunately, as it happens, meaningless (in the upstream context) parts > of the vendor driver were copied, ending up causing havoc - since all > "per-RSC" (in quotes because they all point to the main APPS one) BCMs > defined within the driver overwrite the value in RPMh on every > aggregation. > > To both avoid keeping bogus code around and possibly introducing > impossible-to-track-down bugs (busses shutting down for no reason), get > rid of the duplicated BCMs and their associated ICC nodes. > > Fixes: e6f0d6a30f73 ("interconnect: qcom: Add SM8550 interconnect provider driver") > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx> Regards, Bjorn