Re: [PATCH v3 1/6] dt-bindings: arm: qcom: Document qcs8550 SoC and board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/19/2023 2:56 PM, Krzysztof Kozlowski wrote:
On 19/12/2023 01:50, Tengfei Fan wrote:
Document the qcs8550 SoC and the AIM300 AIoT board bindings.
AIM300 Series is a highly optimized family of modules designed to support
AIoT applications. The Module is mounted onto Qualcomm AIoT carrier board
to support verification, evaluation and development.
AIM stands for Artificial Intelligence Module. AIoT stands for AI IoT.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Drop

Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
---
  Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 1a5fb889a444..a0e3cf271cfe 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -49,6 +49,7 @@ description: |
          msm8996
          msm8998
          qcs404
+        qcs8550
          qcm2290
          qcm6490
          qdu1000
@@ -904,6 +905,12 @@ properties:
            - const: qcom,qcs404-evb
            - const: qcom,qcs404
+ - items:
+          - enum:
+              - qcom,qcs8550-aim300-aiot
+          - const: qcom,qcs8550-aim300
+          - const: qcom,qcs8550
Need to add below line here, right?
+          - const: qcom,sm8550

Missing compatible. Please read previous discussions.
The previous comments was missed. Just double confirm here for "fallback" meaning here.

Could you pls also double confirm for my understandings for the compatible rules? As long as sm8550 was designed "hardware compatible"(pin-to-pin compatible) and "software firmware compatible"(firmware also support sm8550) to qcs8550, it is request to add compatible sm8550 to current compatible sequence like: board/SOM/soc/base soc.

Note that, we don't really have hardware like "sm8550 inside aim300".

Best regards,
Krzysztof


--
Thx and BRs,
Aiqun(Maria) Yu




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux