On 19.12.23 09:12, Krzysztof Kozlowski wrote: > On 19/12/2023 09:06, Jan Kiszka wrote: >> On 19.12.23 08:51, Krzysztof Kozlowski wrote: >>> On 18/12/2023 17:35, Jan Kiszka wrote: >>>> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> >>>> >>>> A new variant is to be added which will not have a arduino connector >>>> like the existing ones. Factor out all bits that are specific to this >>>> connector. >>>> >>>> The split is not perfect because wkup_gpio0 is defined based on what is >>>> common to all variants having the connector, thus containing also >>>> connector-unrelated information. But this is still cleaner than >>>> replicating this node into all 4 variants. >>>> >>>> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> >>>> --- >>>> .../ti/k3-am65-iot2050-arduino-connector.dtsi | 768 ++++++++++++++++++ >>>> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 753 ----------------- >>> >>> Please use proper -B/-M/-C arguments so code movements will be detected. >>> >> >> Those are in place but have no impact, likely because the source file is > > In place as what? > >> still ~700 lines after the shuffling. > > The original file has 720 lines, so if you move 750 (!) of them, I can The original file has 1446 lines - I should have noted that this goes on top of [1] which is already pending for 6.8 in Nishanth's tree, sorry. Jan [1] https://lore.kernel.org/lkml/cover.1699087938.git.jan.kiszka@xxxxxxxxxxx/ > hardly believe the rename cannot be detected. You are basically moving > 90% or 95% of file, so this must be represented with proper diff. > > Your patches do not apply on next, neither on master, so it is tricky to > check. > > How do you expect us to review it? Compare line by line? > > Best regards, > Krzysztof > -- Siemens AG, Technology Linux Expert Center