On 18/12/2023 08:37, Chunyan Zhang wrote: > On Mon, 18 Dec 2023 at 15:31, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 18/12/2023 08:18, Chunyan Zhang wrote: >>> On Mon, 18 Dec 2023 at 15:00, Krzysztof Kozlowski >>> <krzysztof.kozlowski@xxxxxxxxxx> wrote: >>>> >>>> On 18/12/2023 03:31, Chunyan Zhang wrote: >>>>> On Fri, 15 Dec 2023 at 18:36, Krzysztof Kozlowski >>>>> <krzysztof.kozlowski@xxxxxxxxxx> wrote: >>>>>> >>>>>> On 15/12/2023 09:56, Chunyan Zhang wrote: >>>>>>> Add basic support for Unisoc's UMS9620, with this patch, >>>>>>> the board ums9620-2h10 can run into console. >>>>>>> >>>>>> >>>>>> ... >>>>>> >>>>>>> + >>>>>>> + soc: soc { >>>>>> >>>>>> Are you sure you do not have here W=1 warnings? >>>>> >>>>> Do you mean warnings generated by running "make W=1"? I tried just now >>>>> and didn't see warnings on this dts. >>>> >>>> No, I meant `dtbs_check W=1` or W=1 coming from dtc (dtbs). >>> >>> Yes, I just run "make W=1 dtbs", also have tried `dtbs_check W=1`, >>> didn't see warnings on ums9620-2h10.dtb >> >> Ah, because it does not even compile! > > The patch was generated from a middle commit (that was my mistake of course). > > But I've fixed the issue. I ran the command just now according to your > comments, and didn't see the warnings on this dtb. > > If I'm missing something, please correct me. You don't have unit address for soc node, but could be fine if address/size cells match. Don't remember, but also cannot verify because it does not build. :( Best regards, Krzysztof