On Sun, Dec 17, 2023 at 5:58 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote: > > On Sat, Dec 16, 2023 at 11:52 AM Marcelo Schmitt > <marcelo.schmitt@xxxxxxxxxx> wrote: > > > > Implement event configuration callbacks allowing users to read/write > > event thresholds and enable/disable event generation. > > > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> > > --- > > This is from a review suggestion David made on v3 [1]. > > > > Is this the case for a Suggested-by tag? > > > > [1]: https://lore.kernel.org/linux-iio/CAMknhBFPbAqp4-AQdmbp+VRW-Ksk1PxaLCG+3n=Zk4gyStqhgw@xxxxxxxxxxxxxx/#t > > > > I suppose it fits the definition of Suggested-by well enough and would > be appreciated. Even more so on [PATCH v4 02/15] "iio: adc: ad7091r: > Pass iio_dev to event handler". And it seems like this should have the Fixes tag since this is fixing a null pointer dereference. And the commit message should describe the problem and that this as a fix, otherwise it sounds like we are just adding a new feature here.
