Conor Dooley <conor@xxxxxxxxxx> writes: Hello Conor, > On Sun, Dec 17, 2023 at 10:33:24PM +0100, Javier Martinez Canillas wrote: [...] >> >> + then: >> >> + properties: >> >> + width: >> >> + default: 96 >> >> + height: >> >> + default: 64 >> > >> > Do you envisage a rake of devices that are going to end up in this >> > binding? Otherwise, why not unconditionally set the constraints? >> > >> >> Because these are only for the default width and height, there can be >> panels using the same controller but that have a different resolution. >> >> For example, there are panels using the SSD1306 controller that have >> 128x32 [0], 64x32 [1] or 128x64 [2] resolutions. > > This, as you know, does not matter here. > Are you sure? What I tried to say is that the SSD133x are just OLED controllers and manufacturers use those chips to attach a panel that has a certain resolution. While it makes sense to use all the supported width and height, some manufacturers chose to have a smaller panel instead (I used SSD1306 as an example because I knew about these but the same might be true for let's say SSD1331). Or saying another way, are you sure that every manufacturer selling RGB OLED panels using the SSD1331 chip will use the default resolution and users won't have to set a custom width and height ? I have already chosen to make the DT binding as simple as possible to prevent what happened with the SSD1306 "solomon,page-offset" property that has a broken default [0] but I think that not allowing to set the resolution is already too restrictive and would make it unusable for any panel that doesn't have the default width and height. [0]: https://lists.freedesktop.org/archives/dri-devel/2023-November/431150.html >> But answering your question, yes I think that more devices for this >> SSD133x family are going to be added later. Looking at [3], there is >> at least SSD1333 that has a different default resolutions (176x176). > > That's fair enough though. I'd probably err on the side of introducing > this complexity when the other users actually show up though. > Agree and the reason why I did not include entries for the SSD1332 and SSD1333. I was planning to add those only if there were users since it seems that the SSD1331 is the most popular controller from this family. But as explained, even for the SSD1331 it may be needed to set a width and height that is different than the default of this panel controller. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
