On Sat, 16 Dec 2023 14:46:37 -0300
Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> wrote:
> The ad7091r-base driver sets up an interrupt handler for firing events
> when inputs are either above or below a certain threshold.
> However, for the interrupt signal to come from the device it must be
> configured to enable the ALERT/BUSY/GPO pin to be used as ALERT, which
> was not being done until now.
> Enable interrupt signals on the ALERT/BUSY/GPO pin by setting the proper
> bit in the configuration register.
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
Hi Marcelo,
In V3 review I asked if this should have a fixes tag. I've assumed for now
the answer is no and applied it without. If you let me know fast enough
I can probably slip on in, but if not you may want to consider requesting
a backport after this is upstream.
Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to take a look at it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ad7091r-base.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/iio/adc/ad7091r-base.c b/drivers/iio/adc/ad7091r-base.c
> index 0e5d3d2e9c98..8aaa854f816f 100644
> --- a/drivers/iio/adc/ad7091r-base.c
> +++ b/drivers/iio/adc/ad7091r-base.c
> @@ -28,6 +28,7 @@
> #define AD7091R_REG_RESULT_CONV_RESULT(x) ((x) & 0xfff)
>
> /* AD7091R_REG_CONF */
> +#define AD7091R_REG_CONF_ALERT_EN BIT(4)
> #define AD7091R_REG_CONF_AUTO BIT(8)
> #define AD7091R_REG_CONF_CMD BIT(10)
>
> @@ -232,6 +233,11 @@ int ad7091r_probe(struct device *dev, const char *name,
> iio_dev->channels = chip_info->channels;
>
> if (irq) {
> + ret = regmap_update_bits(st->map, AD7091R_REG_CONF,
> + AD7091R_REG_CONF_ALERT_EN, BIT(4));
> + if (ret)
> + return ret;
> +
> ret = devm_request_threaded_irq(dev, irq, NULL,
> ad7091r_event_handler,
> IRQF_TRIGGER_FALLING | IRQF_ONESHOT, name, iio_dev);
