Hi Arnd, Thanks for reviewing On 17 December 2014 at 23:01, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Wednesday 17 December 2014 11:34:43 Gabriel FERNANDEZ wrote: >> sti pcie is built around a Synopsis Designware PCIe IP. >> >> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxx> >> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/pci/st-pcie.txt | 53 +++++++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/st-pcie.txt >> >> diff --git a/Documentation/devicetree/bindings/pci/st-pcie.txt b/Documentation/devicetree/bindings/pci/st-pcie.txt >> new file mode 100644 >> index 0000000..bd3488f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/st-pcie.txt >> @@ -0,0 +1,53 @@ >> +STMicroelectronics STi PCIe controller >> + >> +This PCIe host controller is based on the Synopsis Designware PCIe IP >> +and thus inherits all the common properties defined in designware-pcie.txt. >> + >> +Required properties: >> + - compatible: "st,stih407-pcie" >> + - reg: base address and length of the pcie controller, mem-window address >> + and length available to the controller. >> + - interrupts: A list of interrupt outputs of the controller. >> + - interrupt-names: Must include the following entries: >> + "msi": STi interrupt that is asserted when an MSI is received > > You should specify that only one interrupt may be present. > If you extend the binding, you will need to describe what the > second one is as well. > ok, i will change into: " - interrupts: A list of interrupt outputs of the controller. Must contain an entry for each entry in the interrupt-names property. >> + - st,syscfg : should be a phandle of the syscfg node. Also contains syscfg >> + offset for IP configuration. >> + - resets, reset-names: the power-down and soft-reset lines of PCIe IP. >> + Associated names must be "powerdown" and "softreset". >> + - phys, phy-names: the phandle for the PHY device. >> + Associated name must be "pcie_phy" > > Names should not have underscores in them in general. "pcie-phy" would > be fine, but just "pcie" seems good enough, unless there are existing > drivers that have established a specific naming. > just "pcie" is fine for me BR Gabriel > > Arnd > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
