On Tue, Dec 12, 2023 at 05:49:09PM +0500, Nikita Travkin wrote: > Add binding for the EC found in the Acer Aspire 1 laptop. > > Signed-off-by: Nikita Travkin <nikita@xxxxxxx> > --- > .../bindings/power/supply/acer,aspire1-ec.yaml | 67 ++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/acer,aspire1-ec.yaml b/Documentation/devicetree/bindings/power/supply/acer,aspire1-ec.yaml > new file mode 100644 > index 000000000000..1fbf1272a00f > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/acer,aspire1-ec.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/acer,aspire1-ec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Acer Aspire 1 Embedded Controller > + > +maintainers: > + - Nikita Travkin <nikita@xxxxxxx> > + > +description: > + The Acer Aspire 1 laptop uses an embedded controller to control battery > + and charging as well as to provide a set of misc features such as the > + laptop lid status and HPD events for the USB Type-C DP alt mode. > + > +properties: > + compatible: > + const: acer,aspire1-ec > + > + reg: > + const: 0x76 > + > + interrupts: > + maxItems: 1 > + > + acer,media-keys-on-top: > + description: Configure the keyboard layout to use media features of > + the fn row when the fn key is not pressed. The firmware may choose > + to add this property when user selects the fn mode in the firmware > + setup utility. > + type: boolean Besides the naming, this isn't really a property of the EC, but really part of the keyboard layout. It seems you just stuck it here because this is part of the specific device. It is also hardly a feature unique to this device. I'm typing this from a device with the exact same thing (M1 Macbook Pro). Actually, all 3 laptops I have in front of me have the same thing. The other 2 have a Fnlock (Fn+ESC) though. On the M1, it's just a module param which I set as persistent. Though I now wonder if the Fnlock could be implemented on it too. Being able to switch whenever I want would be nice. That would probably have to be in Linux where as these other laptops probably implement this in their EC/firmware? What I'm getting at is controlling changing this in firmware is not a great experience and this should all be common. Rob