On Wed, Dec 13, 2023, at 20:05, Tomer Maimon wrote:
> Add Nuvoton BMC NPCM BIOS post code (BPC) driver.
>
> The NPCM BPC monitoring two configurable I/O address written by the host
> on the bus.
>
> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> ---
> drivers/soc/nuvoton/Kconfig | 9 +
> drivers/soc/nuvoton/Makefile | 1 +
> drivers/soc/nuvoton/npcm-bpc.c | 387 +++++++++++++++++++++++++++++++++
> 3 files changed, 397 insertions(+)
> create mode 100644 drivers/soc/nuvoton/npcm-bpc.c
I try hard to avoid having user interfaces in drivers/soc/, that
subsystem should primarily be used for things that don't have an
existing subsystem in the kernel and are used by other in-kernel
drivers but don't export hteir own misc device.
> diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig
> index d5102f5f0c28..ebd162633942 100644
> --- a/drivers/soc/nuvoton/Kconfig
> +++ b/drivers/soc/nuvoton/Kconfig
> @@ -2,6 +2,15 @@
>
> menu "NUVOTON SoC drivers"
>
> +config NPCM_BPC
> + tristate "NPCM BIOS Post Code support"
> + depends on (ARCH_NPCM || COMPILE_TEST)
> + help
> + Provides NPCM driver to control the BIOS Post Code
> + interface which allows the BMC to monitor and save
> + the data written by the host to an arbitrary I/O port,
> + the BPC is connected to the host thourgh LPC or eSPI bus.
> +
This one in particular looks like this might be implemented
by more than one BMC type, it's a fairly generic functionality.
Have you talked to the other maintainers of SoCs used in
OpenBMC about coming up with a common interface?
> +#define DEVICE_NAME "npcm-bpc"
[nitpicking] No need for macros like this one, open-coding the
string is usually more readable.
Arnd
