On Wed, Dec 13, 2023 at 11:00:22AM -0700, Mark Hasemeyer wrote: > Similar to of_irq_to_resource_table(), add a default implementation of > of_irq_to_resource() for systems that don't have CONFIG_OF_IRQ defined. ... > +extern int of_irq_to_resource(struct device_node *dev, int index, > + struct resource *r); It looks like you may put this on a single line as this file has longer lines. Note you do not need "extern" for function. You may even update the header to drop all of them at once. -- With Best Regards, Andy Shevchenko