On 13/12/2023 20:01, Konrad Dybcio wrote: > > > On 12/13/23 15:04, Krzysztof Kozlowski wrote: >> On 11/12/2023 11:33, Krzysztof Kozlowski wrote: >>>> @@ -0,0 +1,579 @@ >>>> +// SPDX-License-Identifier: BSD-3-Clause >>>> +/* >>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >>>> + */ >>>> + >>>> +/dts-v1/; >>>> + >>>> +#include <dt-bindings/leds/common.h> >>>> +#include "qcs8550-aim300.dtsi" >>> >>> Which includes sm8550.dtsi thus I think this is compatible with sm8550. >>> You even use sm8550 compatibles here, which is one more hint for that >>> compatibility. >>> >>> We followed this convention for RB5, although not for QRU/QDU1000 boards. >>> >>> Anyway, if you add here new SoC compatible, I would expect to see new >>> SoC DTSI. >>> >>> I don't have in my notes any previous consensus or decision in these >>> matters, so let's discuss now. >>> +CC few Linaro folks >> >> After some talks, the idea is to create qcs8550.dtsi, which will include >> sm8550.dtsi, and add top level compatible for qcs8550 using sm8550 fallback. > To the board device tree? Otherwise it'll get overwritten. Could be both, to serve as a guideline for future DTS, but in general yes, to the board DTS. Best regards, Krzysztof
