Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Krzysztof,

On 12/12/23 14:26, Krzysztof Kozlowski wrote:
On 12/12/2023 17:40, Ninad Palsule wrote:
This drop adds following devices in the device tree.
- EEPROM/VPD
- Power supplies
- Humidity, pressure and temperature sensors.
- Trusted platform module(TPM) chip

Tested:
     This board is tested using the simics simulator.

Signed-off-by: Ninad Palsule <ninad@xxxxxxxxxxxxx>
---
Don't mix DTS with drivers. DTS and drivers go via different subsystems
and cannot have dependencies, so why DTS is patch #6, then driver #7 and
now again DTS #7?

There is a dependency on driver code as patch #8 uses the compatibility string added in driver patch #7.  I have now moved driver patch at the start. Is that ok? OR you are suggesting something else?

v1-0001-tpm-tis-i2c-Add-more-compatible-strings.patch
                        |
v1-0009-ARM-dts-aspeed-System1-PS-sensor-and-more.patch


  .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 76 +++++++++++++++++++
  1 file changed, 76 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
index 75562aa63701..d960b938fe8d 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
@@ -461,6 +461,11 @@ &kcs3 {
  &i2c0 {
  	status = "okay";
+ eeprom@50 {
+		compatible = "atmel,24c64";
+		reg = <0x50>;
+	};
+
  	regulator@60 {
  		compatible = "maxim,max8952";
  		reg = <0x60>;
@@ -655,6 +660,25 @@ pca0: pca9539@74 {
&i2c2 {
  	status = "okay";
+
+	power-supply@58 {
+		compatible = "ibm,cffps";
+		reg = <0x58>;
+	};
+
+	power-supply@59 {
+		compatible = "ibm,cffps";
+		reg = <0x59>;
+	};
+
+	power-supply@5a {
+		compatible = "ibm,cffps";
+		reg = <0x5a>;
+	};
Missing blank line

Fixed it.

Thanks for the review.

Regards,

Ninad


+	power-supply@5b {
+		compatible = "ibm,cffps";
+		reg = <0x5b>;
+	};

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux