On Sat, Dec 09, 2023 at 02:48:27AM +0100, Christian Marangi wrote: > Add Documentation for QCA808x PHYs for the additional property for the > active high LED setting and also document the LED configuration for this > PHY. > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > --- > .../devicetree/bindings/net/qca,qca808x.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/qca,qca808x.yaml > > diff --git a/Documentation/devicetree/bindings/net/qca,qca808x.yaml b/Documentation/devicetree/bindings/net/qca,qca808x.yaml > new file mode 100644 > index 000000000000..73cfff357311 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qca,qca808x.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: GPL-2.0+ Dual license as checkpatch.pl points out. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/qca,qca808x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Atheros QCA808X PHY > + > +maintainers: > + - Christian Marangi <ansuelsmth@xxxxxxxxx> > + > +description: > + Bindings for Qualcomm Atheros QCA808X PHYs > + > + QCA808X PHYs can have up to 3 LEDs attached. > + All 3 LEDs are disabled by default. > + 2 LEDs have dedicated pins with the 3rd LED having the > + double function of Interrupt LEDs/GPIO or additional LED. > + > + By default this special PIN is set to LED function. > + > +allOf: > + - $ref: ethernet-phy.yaml# > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - ethernet-phy-id004d.d101 Move this to properties and drop the select. > + required: > + - compatible > + > +properties: > + qca,led-active-high: > + description: Set all the LEDs to active high to be turned on. > + type: boolean > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/leds/common.h> > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-phy@0 { > + compatible = "ethernet-phy-id004d.d101"; > + reg = <0>; > + qca,led-active-high; > + > + leds { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + color = <LED_COLOR_ID_GREEN>; > + function = LED_FUNCTION_WAN; > + default-state = "keep"; > + }; > + }; > + }; > + }; > -- > 2.40.1 >