On Thu, Dec 7, 2023 at 8:08 AM Claudiu <claudiu.beznea@xxxxxxxxx> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > > The intention of the SW_SD0_DEV_SEL and SW_SD2_EN macros was to reflect the > state of SW_CONFIG individual switches available on the RZ/G3S Smarc Module > and at the same time to have a descriptive name for the switch itself. > Each individual switch is associated with a signal name, which might be > active-low or not on the board. Using signal names instead of SW_CONFIG > switch names may be confusing for a user who just playes with switches to > select individual functionalities, but also for the advanced user that > looks over schematics. To avoid even further confusions, use the switches' > names here and instantitate them with an ON/OFF state. This should be > simpler, even though the name of the switch is not that intuitive. The > switch names documentation reflects the switch's purpose. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > --- > > Changes in v2: > - this patch is new and aims to replace patch "arm64: renesas: rzg3s-smarc-som: > Invert the logic of the SW_SD2_EN macro" from v1 Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v6.8. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds