On Tue, Dec 12, 2023 at 01:08:31PM +0800, Shenghao Ding wrote: > Remove tas2563 from tas2562, it will be supported in separated driver code. No objection from the code perspective. The Q is, what is the behaviour of the current users? Imagine we have a used of this chip and this driver gets it enumerated. Does it work? if so, this patch can not be applied right now. Otherwise the commit message above is missing an elaboration of the case. -- With Best Regards, Andy Shevchenko