JeeHeng Sia wrote: > > -----Original Message----- > > From: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> > > Sent: Saturday, December 9, 2023 12:37 AM > > To: JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx>; kernel@xxxxxxxx; conor@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > > krzysztof.kozlowski+dt@xxxxxxxxxx; paul.walmsley@xxxxxxxxxx; palmer@xxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx; > > mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; emil.renner.berthing@xxxxxxxxxxxxx; Hal Feng > > <hal.feng@xxxxxxxxxxxxxxxx>; Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> > > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; Leyfoon Tan > > <leyfoon.tan@xxxxxxxxxxxxxxxx> > > Subject: Re: [PATCH v1 07/16] dt-bindings: clock: Add StarFive JH8100 System-North-West clock and reset generator > > > > Sia Jee Heng wrote: > > > Add bindings for the System-North-West clock and reset generator > > > (SYSCRG-NW) on JH8100 SoC. > > > > > > Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx> > > > Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx> > > > --- > > > .../clock/starfive,jh8100-syscrg-nw.yaml | 119 ++++++++++++++++++ > > > > The JH7110 clocks, the JH8100 system and always-on all follow the Xcrg pattern: > > syscrg > > aoncrg > > stgcrg > > ispcrg > > voutcrg > > etc. > > > > Is there a reason the north-west, north-east and south-west breaks this pattern? > > I'd have expected them to be called something like > > nwcrg, JH8100_NWCLK_*, JH8100_NWRST_*, > > necrg, JH8100_NECLK_*, JH8100_NERST_* and > > swcrg, JH8100_SWCLK_*, JH8100_SWRST_* > > > > Just like all the other Starfive drivers. > Understood your concern. We don’t have the intention to break the pattern, > but the reason we skip the SoC_ prefix is that the SoC names were already > defined in the header file with the SoC name. > However, I can put it back, of course. Yes, all these 3 JHXX00 drivers are almost identical. There should be no reason to name any one of them differently. Having them all be as similar as possible will make it a lot easier to maintain in the future. If you don't like a pattern then please change it for all the similar drivers and don't make just one of them be different. /Emil
