> -----Original Message----- > From: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> > Sent: Saturday, December 9, 2023 12:25 AM > To: JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx>; kernel@xxxxxxxx; conor@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; paul.walmsley@xxxxxxxxxx; palmer@xxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx; > mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; emil.renner.berthing@xxxxxxxxxxxxx; Hal Feng > <hal.feng@xxxxxxxxxxxxxxxx>; Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; Leyfoon Tan > <leyfoon.tan@xxxxxxxxxxxxxxxx> > Subject: Re: [PATCH v1 06/16] clk: starfive: Add JH8100 System clock generator driver > > Sia Jee Heng wrote: > > Add support for JH8100 System clock generator. > > > > Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx> > > Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx> > > --- > > MAINTAINERS | 8 + > > drivers/clk/starfive/Kconfig | 9 + > > drivers/clk/starfive/Makefile | 1 + > > drivers/clk/starfive/clk-starfive-common.h | 9 +- > > drivers/clk/starfive/jh8100/Makefile | 3 + > > .../clk/starfive/jh8100/clk-starfive-jh8100.h | 11 + > > drivers/clk/starfive/jh8100/clk-sys.c | 455 ++++++++++++++++++ > > 7 files changed, 495 insertions(+), 1 deletion(-) > > create mode 100644 drivers/clk/starfive/jh8100/Makefile > > create mode 100644 drivers/clk/starfive/jh8100/clk-starfive-jh8100.h > > create mode 100644 drivers/clk/starfive/jh8100/clk-sys.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 788be9ab5b73..87bcb25becc1 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -20763,6 +20763,14 @@ F: Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > > F: drivers/phy/starfive/phy-jh7110-pcie.c > > F: drivers/phy/starfive/phy-jh7110-usb.c > > > > +STARFIVE JH8100 CLOCK DRIVERS > > +M: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx> > > +M: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx> > > +S: Maintained > > +F: Documentation/devicetree/bindings/clock/starfive,jh81*.yaml > > +F: drivers/clk/starfive/jh8100 > > +F: include/dt-bindings/clock/starfive?jh81*.h > > + > > STATIC BRANCH/CALL > > M: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > > M: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> > > diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig > > index ff8eace36e64..d8c7b9bb3895 100644 > > --- a/drivers/clk/starfive/Kconfig > > +++ b/drivers/clk/starfive/Kconfig > > @@ -72,3 +72,12 @@ config CLK_STARFIVE_JH7110_VOUT > > help > > Say yes here to support the Video-Output clock controller > > on the StarFive JH7110 SoC. [...] > > diff --git a/drivers/clk/starfive/jh8100/Makefile b/drivers/clk/starfive/jh8100/Makefile > > new file mode 100644 > > index 000000000000..af6a09e220d3 > > --- /dev/null > > +++ b/drivers/clk/starfive/jh8100/Makefile > > @@ -0,0 +1,3 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +# StarFive JH8100 Clock > > +obj-$(CONFIG_CLK_STARFIVE_JH8100_SYS) += clk-sys.o > > This will name the module clk-sys, which is way too generic. Please name this > clk-starfive-jh8100-sys similar to the JH7110 drivers. Just realized that I haven't reply to this comment. I can't give it a longer name otherwise compiler will throw warning. That’s why ends up to use a shorter name and keep it under jh8100 folder. > [...]
