On 08.12.2023 17:12:24, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > CAN bus clock. The bus clock was omitted when the binding was written, > but is required for operation. Make up for lost time and add it. > > Cautionary tale in adding bindings without having implemented a real > user for them perhaps. > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > index 45aa3de7cf01..05f680f15b17 100644 > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > @@ -24,7 +24,10 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 1 > + maxItems: 2 > + items: > + - description: AHB peripheral clock > + - description: CAN bus clock Do we we want to have a "clock-names" property, as we need the clock rate of the CAN bus clock. Marc > > required: > - compatible > @@ -39,7 +42,7 @@ examples: > can@2010c000 { > compatible = "microchip,mpfs-can"; > reg = <0x2010c000 0x1000>; > - clocks = <&clkcfg 17>; > + clocks = <&clkcfg 17>, <&clkcfg 37>; > interrupt-parent = <&plic>; > interrupts = <56>; > }; Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature