On Tue, Dec 05, 2023 at 04:22:56PM +0100, Nuno Sa via B4 Relay wrote: > From: Nuno Sa <nuno.sa@xxxxxxxxxx> > > The LTC4282 hot swap controller allows a board to be safely inserted and > removed from a live backplane. Using one or more external N-channel pass > transistors, board supply voltage and inrush current are ramped up at an > adjustable rate. An I2C interface and onboard ADC allows for monitoring > of board current, voltage, power, energy and fault status. > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > --- > + > +power1_good Power considered good I really don't like this attribute. Like the ones below it is non-standard and invisible for standard applications. On top of that, I think it isn't really related to "power" but to the output voltage. What does it actually report that isn't included in the FET faults ? > +fet_short_fault FET short alarm > +fet_bad_fault FET bad alarm Those attributes have little value since they are not standard attributes and won't be seen by standard applications. On top of that, it is not clear (not documented) what the attribute actually reports. I assume it is associated with the output voltage, i.e., in0, but that is just an assumption. What do you think about introducing a standard inX_fault attribute ? It would not be as specific as short/bad, but I think it would be more useful and we could add it to the ABI. > +fault_logs_reset Clears all the Logged Faults What exactly does that do that is user visible ? Thanks, Guenter
