Hi Andy, Am Montag, 11. Dezember 2023, 11:50:23 CET schrieb Andy Yan: > Add Cool Pi CM5 EVB, a board powered by RK3588 > > Signed-off-by: Andy Yan <andyshrk@xxxxxxx> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> I just realized your mention of this being a som + baseboard combination in the previous version. In that case the compatible really should reflect that. - description: Cool Pi Compute Module 5(CM5) EVB items: - const: coolpi,pi-cm5-evb - const: coolpi,pi-cm5 - const: rockchip,rk3588 Similar to how all the other som + baseboard combinations do it (Edgeble neural modules, engicam px30, Thebroma-SoMs). Thanks Heiko > --- > > (no changes since v2) > > Changes in v2: > - change board compatible from "CoolPi CM5 EVB" to "coolpi,pi-cm5-evb" > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 11d03035f3db..4da83bbd642a 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -95,6 +95,11 @@ properties: > - const: chipspark,rayeager-px2 > - const: rockchip,rk3066a > > + - description: Cool Pi Compute Module 5(CM5) EVB > + items: > + - const: coolpi,pi-cm5-evb > + - const: rockchip,rk3588 > + > - description: Cool Pi 4 Model B > items: > - const: coolpi,pi-4b >