On 11/12/2023 00:47, Shenghao Ding wrote: > Support tas2563. > > Signed-off-by: Shenghao Ding <shenghao-ding@xxxxxx> > > --- > Change in v2: > - Add devicetree list and other list of necessary people and lists to CC > - Express Compatibility in the bindings > - Drop driver changes > --- > .../devicetree/bindings/sound/ti,tas2781.yaml | 26 +++++++++++++------ > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > index a69e6c223308..c049fe6b2dad 100644 > --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > @@ -5,17 +5,17 @@ > $id: http://devicetree.org/schemas/sound/ti,tas2781.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Texas Instruments TAS2781 SmartAMP > +title: Texas Instruments TAS2781/TAS2563 SmartAMP > > maintainers: > - Shenghao Ding <shenghao-ding@xxxxxx> > > description: > - The TAS2781 is a mono, digital input Class-D audio amplifier > - optimized for efficiently driving high peak power into small > - loudspeakers. An integrated on-chip DSP supports Texas Instruments > - Smart Amp speaker protection algorithm. The integrated speaker > - voltage and current sense provides for real time > + The TAS2781/TAS2563 is a mono, digital input Class-D audio > + amplifier optimized for efficiently driving high peak power into > + small loudspeakers. An integrated on-chip DSP supports Texas > + Instruments Smart Amp speaker protection algorithm. The > + integrated speaker voltage and current sense provides for real time > monitoring of loudspeaker behavior. > > allOf: > @@ -23,18 +23,28 @@ allOf: > > properties: > compatible: > + description: | > + ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker > + Protection and Audio Processing, 16/20/24/32bit stereo I2S or > + multichannel TDM. > + > + ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated > + DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM. > enum: > - ti,tas2781 > + - ti,tas2563 I don't think you tested your DTS. Where is the compatibility / fallback? Best regards, Krzysztof