On Mon, 11 Dec 2023 at 11:11, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > On 9.12.2023 22:56, Dmitry Baryshkov wrote: > > On SM8150 the RPMh stats have 3 data records, but no DDR sleep stats, > > which demands platform-specific compatible and data. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > I don't think it makes sense considering the driver could detect the > presence (or possibility of presence) of DDR stats at runtime. No, it can not really. We have safety nets for checking the offset value and then checking the magic number. But I'd prefer to be explicit here. It's not that the 'invalid' data at this offset is 0 or ~0. So, I'd prefer to be explicit here. Actually we probably should have used SoC compat entries from the beginning, even if looks ridiculous for such small thing. -- With best wishes Dmitry
