On Wed, Nov 29 2023 at 13:43, James Tai wrote: > Add support for the RTD1319 platform. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: > https://lore.kernel.org/oe-kbuild-all/202311061208.hJmxGqym-lkp@xxxxxxxxx/ Again: These tags are just wrong. > +static struct platform_driver realtek_intc_rtd1319_driver = { > + .probe = rtd1319_intc_probe, > + .driver = { > + .name = "realtek_intc_rtd1319", > + .of_match_table = realtek_intc_rtd1319_dt_matches, > + .suppress_bind_attrs = true, > + .pm = &realtek_intc_rtd1319_pm_ops, > + }, .probe = rtd1319_intc_probe, .driver = { .name = "realtek_intc_rtd1319", .of_match_table = realtek_intc_rtd1319_dt_matches, .... Please. > +}; > + > +static int __init realtek_intc_rtd1319_init(void) > +{ > + return platform_driver_register(&realtek_intc_rtd1319_driver); > +} > +core_initcall(realtek_intc_rtd1319_init); What? This can be built as a module. So how is core_initcall() in any way correct here? module_init() perhaps? Thanks, tglx
