On Fri, 08 Dec 2023 15:51:20 +0100 Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> wrote: > Hello Marek and Sjoerd, > > > It seems the moxtet bus support was broken since 21aad8ba615e ("arm64: > > dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two > > reasons: > > * The moxtet irq isn't marked as shared so the driver fails to load if > > the rtc driver gets set up first. > > * The dts change didn't set the IRQ type, so in case the rtc driver got > > probed first irq setup ended up wrong (rising instead of falling edge). > > > > On top of that the moxtet module isn't auto-loading due to a missing spi > > table > > > > Changes in v2: > > - Add cover letter > > - Add patch to set the irq type > > > > Sjoerd Simons (3): > > bus: moxtet: Mark the irq as shared > > bus: moxtet: Add spi device table > > arm64: dts: armada-3720-turris-mox: set irq type for RTC > > I only received the previous patch in my inbox, I plan to apply it. But > what about the 2 other patches ? Marek will you do a pull request with > these 2 patches or do you expect that I take them also ? > > Regards, > > Gregory Gregory, as of yet I've never done a pull request. If you are willing to take all 3 patches now, please do. In the future I would like to start doing it for Turris stuff, if you are OK with it. Marek