Hi Krzysztof, >On 29/11/2023 06:43, James Tai wrote: >> Add the YAML documentation for Realtek DHC (Digital Home Center) SoCs. >> >> Reported-by: kernel test robot <lkp@xxxxxxxxx> >> Closes: >> https://lore.kernel.org/oe-kbuild-all/202311180921.ayKhiFHL-lkp@intel. >> com/ > >Drop both. They are not applicable to this patch. > Okay. I will drop them. >> CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx> >> CC: Marc Zyngier <maz@xxxxxxxxxx> > >> CC: Rob Herring <robh+dt@xxxxxxxxxx> >> CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> >> CC: Conor Dooley <conor+dt@xxxxxxxxxx> >> CC: linux-kernel@xxxxxxxxxxxxxxx >> CC: devicetree@xxxxxxxxxxxxxxx > >Please drop the autogenerated scripts/get_maintainer.pl CC-entries from >commit msg. There is no single need to store automated output of >get_maintainers.pl in the git log. It can be easily re-created at any given time, >thus its presence in the git history is redundant and obfuscates the log. > >If you need it for your own patch management purposes, keep it under the >--- separator. > I will move the CC-entries under the '---' separator. >My previous comments were not addressed. Why lines are not described >(items: description:)? Are they all the same? Why you did not respond to clarify >this comment? > I've addressed the previous comments and will include a description for each line in the next patches. I misunderstood your meaning, so I did not provide a clear response. >The rest of my comment here was also ignored. You cannot just ignore >comments, but must respond to them or implement them. > I will improve this part. >To clarify: I expect allOf: block after required: constraining the interrupts per >variant. > I will adjust it in next patches. Regards, James
