On Thu, 2023-12-07 at 15:20 +0000, Lee Jones wrote: > On Tue, 28 Nov 2023, Shawn Anastasio wrote: > > > From: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx> > > > > The Sony Cronos Platform Controller CPLD is a multi-purpose > > platform > > controller that provides both a watchdog timer and an LED > > controller for > > the Sony Interactive Entertainment Cronos x86 server platform. As > > both > > functions are provided by the same CPLD, a multi-function device is > > exposed as the parent of both functions. > > > > Signed-off-by: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx> > > --- > > Changes in v2: > > - Change SIE to Sony (SIE's parent company) to be more consistent > > with how other subsidiaries are treated in the kernel > > - Fix build issue under !CONFIG_OF discovered by kernel test > > robot > > Does this driver work without Device Tree? > > Why can't you just drop the of_match_ptr()? > > > by guarding definition of `cronos_cpld_dt_ids` as is done in > > other > > drivers. > > > > MAINTAINERS | 7 + > > drivers/mfd/Kconfig | 11 + > > drivers/mfd/Makefile | 1 + > > drivers/mfd/sony-cronos-cpld.c | 591 > > ++++++++++++++++++++++ > > include/linux/mfd/sony/cronos/core.h | 17 + > > include/linux/mfd/sony/cronos/registers.h | 59 +++ > > 6 files changed, 686 insertions(+) > > create mode 100644 drivers/mfd/sony-cronos-cpld.c > > create mode 100644 include/linux/mfd/sony/cronos/core.h > > create mode 100644 include/linux/mfd/sony/cronos/registers.h > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 6c4cce45a09d..623681826820 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19932,6 +19932,13 @@ S: Maintained > > F: drivers/ssb/ > > F: include/linux/ssb/ > > > > +SONY CRONOS CPLD DRIVER > > +M: Georgy Yakovlev <Georgy.Yakovlev@xxxxxxxx> > > Are they aware of this? > > They do not appear to be in the submission path. Hello, I'm aware, just watching and learning. > > > +S: Maintained <rest snipped>
