On Thu, Dec 07, 2023 at 06:03:44PM +0100, Krzysztof Kozlowski wrote: > On 06/12/2023 13:45, Daniel Golle wrote: > >>> +properties: > >>> + compatible: > >>> + items: > >>> + - const: mediatek,mt7988-ethwarp > >>> + - const: syscon > >>> + - const: simple-mfd > >> > >> No, this is not a mfd, I say. > >> > >> Prove me wrong! :-) > > > > https://github.com/dangowrt/linux/blob/mt7988-for-next/arch/arm64/boot/dts/mediatek/mt7988a.dtsi#L564 > > > > The 'simple-mfd' compatible is required to have the Linux > > kernel probe drivers for sub-nodes -- several drivers will act on > > the different aspects of the circuit exposed at this memory range. > > From what I understand, this is the definition of a MFD. > > We know what is MFD, so no need to teach us. We expect you to look at > this. You do not have subnodes, so MFD is pointless. Showing DTSI means > nothing except that you did not test your bindings. Sorry, I simply wasn't aware that this is what I'm being asked for. Is the device a MFD? - Yes it is. In this case the child node would be a 'ti,syscon-reset' which doesn't have YAML bindings. Should I include it as object without $ref or do I need to convert ti,syscon-reset.txt to yaml first, and then reference it as child node in the MFD?
