On Thu, Jan 15, 2015 at 4:42 PM, Rob Herring <robherring2@xxxxxxxxx> wrote: > On Thu, Jan 15, 2015 at 7:55 AM, Mark Rutland <mark.rutland@xxxxxxx> wrote: >> On Thu, Jan 15, 2015 at 01:52:01PM +0000, Mark Rutland wrote: >>> On Wed, Jan 14, 2015 at 08:58:18PM +0000, Suman Anna wrote: >>> > +- hwlock-base-id: An unique base Id for the locks for a particular hwlock >>> > + device. This property is mandatory for all platform >>> > + implementations. >>> >>> This property makes no sense. The ID encoded in the hwlock cells is >>> relative to the instance (identified by phandle), not global. So the DT >>> has no global ID space. >>> >>> Why do you think you need this? >> >> Having looked at the way this proeprty is used, NAK. >> >> If you need to carve up a Linux-internal ID space, do that dynamically. >> There is no need for this property. > > Better yet, don't create a Linux ID space for this. Everywhere we have > one, we want to get rid of it. Rob, Mark, The hwlock is a basic hardware primitive that allow synchronization between different processors in the system, which may be running Linux as well as other operating systems, and may have no other means of communication. The hwlock id numbers are predefined, global and static across the entire system: Linux may boot well after other operating systems are already running and using these hwlocks to communicate, and therefore, in order to use these hardware devices, it must not enumerate them differently than the rest of the system. Given that these id numbers are global, system-wide, static and predefined, where Linux may just be one user of them, please reconsider the approach as implemented by Suman, or suggest an alternative one you may prefer. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
