On 07/12/2023 11:07, TY Chang wrote: > From: Tzuyi Chang <tychang@xxxxxxxxxxx> > > Add the device tree bindings for the Realtek DHC(Digital Home Center) > RTD SoCs GPIO controllers. > > Signed-off-by: Tzuyi Chang <tychang@xxxxxxxxxxx> > --- > v2 to v3 change: > 1. Remove generic compatible and use SoC-specific compatible instead. > v1 to v2 change: > 1. Add description for DHC RTD SoCs. > 2. Revise the compatible names. > 3. Add descriptions for reg and interrupts properties. > --- > .../bindings/gpio/realtek,rtd-gpio.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml b/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml > new file mode 100644 > index 000000000000..984e7dbd322e > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2023 Realtek Semiconductor Corporation > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/realtek,rtd-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek DHC GPIO controller > + > +maintainers: > + - Tzuyi Chang <tychang@xxxxxxxxxxx> > + > +description: > + The GPIO controller is designed for the Realtek DHC (Digital Home Center) > + RTD series SoC family, which are high-definition media processor SoCs. > + > +properties: > + compatible: > + enum: > + - realtek,rtd1295-misc-gpio > + - realtek,rtd1295-iso-gpio > + - realtek,rtd1395-iso-gpio > + - realtek,rtd1619-iso-gpio > + - realtek,rtd1319-iso-gpio > + - realtek,rtd1619b-iso-gpio > + - realtek,rtd1319d-iso-gpio > + - realtek,rtd1315e-iso-gpio If there is going to be resend, please order this list alphanumerically. > + > + reg: > + items: > + - description: GPIO controller registers > + - description: GPIO interrupt registers > + ... > + > +additionalProperties: false > + > +examples: > + - | > + gpio@100 { > + compatible = "realtek,rtd1319d-iso-gpio"; > + reg = <0x100 0x100>, > + <0x000 0x0b0>; That's odd. Why order is decreasing? Isn't 0x0 the address of the SoC (soc@0)? It is, btw, 0x0, not 0x000. The same for 0x0b0 -> 0xb0, unless you want to pad to full word. Best regards, Krzysztof
