On Tue, Dec 5, 2023 at 12:13 PM Tim Harvey <tharvey@xxxxxxxxxxxxx> wrote: > > On Thu, Nov 30, 2023 at 2:33 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Thu, Nov 30, 2023 at 1:28 PM Fabio Estevam <festevam@xxxxxxxxx> wrote: > > > > > > Hi Rob, > > > > > > On Thu, Nov 30, 2023 at 4:18 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > > > > The imx8mm-venice boards PCI bus nodes are a complete mess. The > > > > unit-addresses are wrong. The PCI bridge nodes are incomplete missing > > > > "device_type" and "ranges" and just wrong for "#address-cells" and > > > > "#size-cells" values. > > > > > > > > All of these issues are reported warnings if anyone bothered to pay > > > > attention. Sigh. > > Rob, > > Sorry about that. At the time the dt was submitted there were still so > many dt warnings it wasn't very clear what was a legitimate issue and > the PCI bindings are not that easy to understand. > > > > > > > The warnings are gone in linux-next: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/arm64/boot/dts/freescale?h=next-20231130&id=d61c5068729a76a6183a897bcad4bf26e8d3d674 > > > > Linux-next is wrong. The ethernet device should have a node name of > > 'ethernet'. The 'pcie' node name and 'device_type = "pci"' is for PCI > > buses/bridges only. > > So as Fabio has tried to fix this with a patch that landed in > linux-next this patch won't apply. I'll submit one that covers your > changes. Thanks. > It's always been unfortunate to have to have this level of detail in a > device-tree just to allow boot firmware to populate the mac address of > a PCI ethernet device. More unfortunate are incomplete h/w designs lacking the MAC address. :( Not really any way around it I think if you want something that works for any device and any number of devices. Rob
