On Wed, Dec 06, 2023 at 05:31:06PM +0800, Shawn Guo wrote: > On Wed, Dec 06, 2023 at 12:46:15AM -0500, Frank Li wrote: > > On Mon, Nov 27, 2023 at 09:35:39AM +0000, Conor Dooley wrote: > > > On Mon, Nov 27, 2023 at 10:21:40AM +0800, Shawn Guo wrote: > > > > On Thu, Nov 09, 2023 at 10:51:13AM -0500, Frank Li wrote: > > > > > On Tue, Oct 17, 2023 at 03:46:57PM -0400, Frank Li wrote: > > > > > > Add I3C1 and I3C2. > > > > > > > > > > > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > > > > > > --- > > > > > > > > > > @Guo Shawn: > > > > > > > > > > Driver part already merged. > > > > > > > > > > Please pick up dts part > > > > > > > > Rob had a comment [1] about SoC specific compatible. That's not what we > > > > want? > > > > > > > > Shawn > > > > > > > > [1] https://lkml.iu.edu/hypermail/linux/kernel/2310.2/03035.html > > > > > > Yeah, Rob's request here looks valid to me. Should just be a bindings > > > change Frank & fall back to the "silvaco,i3c-master-v1" compatible. > > > > > > Cheers, > > > Conor. > > > > @shawn: > > rob agree on "silvaco,i3c-master-v1" compatible. > > Hmm, not sure I have seen that. Here is what I saw from Rob: > > " > The real problem here is not whether we have "v1" or not, but you need > an SoC specific compatible. Unless there's a public spec where we can > know exactly how many resets, clocks, interrupts, etc. > " @Rob: Previous existed binding doc is "silvaco,i3c-master-v1". So far this IP in our difference SOC have the same resets and clocks, and only one interrrupts. current existed i3c controller compatible string is snps,dw-i3c-master-1.00a cdns,i3c-master mipi-i3c-hci mipi-i3c-hci is standard. "snps", "cdns" are similar as prefix "silivaco". I think the same IP vendor and same IP version should have same resets, clocks, and interrupts. So far still not met exception yet. Frank > > Shawn
